adds options.type override #9
Open
+61
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 11, 2019 12:10
tompascall
requested changes
Sep 12, 2019
| @@ -0,0 +1,18 @@ | |||
| { | |||
There was a problem hiding this comment.
I think we don't need this file
|
Please look how I resolved the similar issue in Vue components #10. We can just consider such cases internally without requiring of external configuration |
|
Hi, thanks for the contribution, the new version has been published to npm
as version 1.2.0.
…On Mon, 17 Aug 2020 at 11:36, Constantine Genchevsky < ***@***.***> wrote:
Please look how I resolved the similar issue in Vue components #10
<#10>. We can
just consider such cases internally without requiring of external
configuration
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTTKQCDCO4EJCZ37N5WQODSBD22DANCNFSM4IVX3C2A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using Semantic UI Less, and because some of the files processed by less do not contain .less as the extension, the plugin doesn't work for me as expected.
I must import the variables here: https://glitch.com/edit/equinox-motion?path=ui/styles/semantic.less:15:17 so that your loader will know what type of variables to create.
But due to the load order, I need to import the variables here: https://glitch.com/edit/#!/equinox-motion?path=ui/styles/site/globals/site.variables:1 so that they actually override the defaults.
I expect that I will be able to move the require statements to the .variables file and update webpack.config to